[event-hubs] update sendBatch to accept lists of events #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
added
Client
chradek
requested review from
bterlson,
ramya-rao-a and
richardpark-msft
as code owners
ramya-rao-a
reviewed
Apr 30, 2020
| * events are sent to the associated Event Hub. | ||
| * - `abortSignal` : A signal the request to cancel the send operation. | ||
| * - `partitionId` : The partition this batch will be sent to. If set, `partitionKey` can not be set. | ||
| * - `partitionKey` : A value that is hashed to produce a partition assignment. |
There was a problem hiding this comment.
Suggested change
| * - `partitionKey` : A value that is hashed to produce a partition assignment. | |
| * - `partitionKey` : A value that is hashed to produce a partition assignment. If set, `partitionId` can not be set. |
There was a problem hiding this comment.
Updated, thank you!
ramya-rao-a
reviewed
Apr 30, 2020
| * Options to configure the `sendBatch` method on the `EventHubProducerClient`. | ||
| * Options to configure the `sendBatch` method on the `EventHubProducerClient` | ||
| * when sending an array of events. | ||
| * If `partitionId` is set, `partitionKey` must not be set. |
There was a problem hiding this comment.
Suggested change
| * If `partitionId` is set, `partitionKey` must not be set. | |
| * If `partitionId` is set, `partitionKey` must not be set and vice versa. |
There was a problem hiding this comment.
Updated, thank you!
ramya-rao-a
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
In Service Bus, we are re-using the batch class and using tryAdd when sending array of messages.
I prefer the approach here because we get to skip being in the business of forming the error message when batch is too big, we rely on the service instead.
On the other hand, there is a lot of duplicated code lying around in this approach.
For now, lets go ahead with what we have here.
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8470
Updates the
EventHubProducerClient.sendBatchmethod to also accept an array ofEventDataBatch. This also necessitated adding a newoptionstype that let's the user specify apartitionKeyorpartitionId.Because of the additional options, I also needed to add validation to ensure that none of the options conflicted with the options that can be set on a batch in the
createBatchcall.