Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dev-tool to the repo #7872
Adding dev-tool to the repo #7872
Changes from 14 commits
12b99c3
8a01be3
7970f3e
ae97341
4379675
bbd0d47
8c790ce
d746960
2e70796
b024362
47ef1cb
2a6a129
a4a4051
5e95de2
96238ab
771869d
2401ec8
4160090
127a7d9
b7752c8
80decda
3b44d8f
1cbef16
ed3df4d
b7ae412
440c499
9d14e4e
f7416ef
2832fd2
09fd249
155bb5b
609b38b
f3cd0ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to conflate how the
DEBUG
variable works, as it could be set to a value that disables logging for all but one particular channel. I have mixed feelings about using this without taking a dep ondebug
or using similar semantics to it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a
LOG_DEBUG
environment variable? I don't want to get too caught up in implementing the semantics ofdebug
, when I think a simple toggle switch will do here. I could also add a--debug
flag that is handled specially in the same way that--help
is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea! But my brain can't parse this :( I'm reading something like
JS\teπteet
😅 Perhaps it's how GitHub presents it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, now I can't unsee it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks better in the cmd-prompt/terminal. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use TSDoc? I like the idea of having the editor show what things mean. I think TSDoc would help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels weird to have a mix of straight
console.log
with a customlog
methodThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I don't want the command namespace prepended to each message, which we do generally want for logging messages and output from commands. This command is a little special in that regard in that it's printing straight to the console, so that's why there's the disconnect. I don't expect the output functions to be mixed anywhere else.