Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Test utilities in a separate folder, through symbolic links and scripts #7612

Closed

Conversation

sadasant
Copy link
Contributor

@sadasant sadasant commented Mar 2, 2020

This PR is part of a set of PRs made to explore together what are the possibilities of having, and managing, common code dependencies.

In this specific PR, we'll be exploring how it would be to move the common code out of KeyVault-Keys into a separate folder, bundled together through symbolic links and scripts.

Things to consider:

  • I haven't moved out the same common test code from KeyVault-Secrets and KeyVault-Certificates to avoid having to have so many changes in one single PR.
  • CI might not pass right away, but I'm confident I can get it to work once we pick an approach.

To do:

  • Clean up this PR.
  • Use inlinesources instead of having the src folder in the package.json's files, and remove the prepack and postpack scripts.
  • Fix CI.

Your review is appreciated.

@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Mar 2, 2020
@sadasant sadasant self-assigned this Mar 2, 2020
@sadasant sadasant changed the title [KeyVault] Test utilities in separate folder, through symbolic links and scripts [KeyVault] Test utilities in a separate folder, through symbolic links and scripts Mar 2, 2020
"integration-test:browser": "karma start --single-run",
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter mocha-multi --reporter-options spec=-,mocha-junit-reporter=- --timeout 5000000 --full-trace dist-esm/test/*.test.js",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint:fix": "eslint package.json tsconfig.json src test samples --ext .ts --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json tsconfig.json src test samples --ext .ts -f html -o keyvault-keys-lintReport.html || exit 0",
"lint:terminal": "eslint package.json tsconfig.json src test samples --ext .ts",
"prepack": "bash ../prepack.sh",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this won't work in command prompt on windows, yeah?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! This is only a draft. If we end up picking this approach, I can write something on another language (let's say, JavaScript 😋 )

@sadasant
Copy link
Contributor Author

Closing this on favor of: #8866

@sadasant sadasant closed this May 12, 2020
@sadasant sadasant deleted the keyvault/test-utils-no-package branch May 12, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants