-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KeyVault] Test utilities in a separate folder, through symbolic links and scripts #7612
Conversation
"integration-test:browser": "karma start --single-run", | ||
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter mocha-multi --reporter-options spec=-,mocha-junit-reporter=- --timeout 5000000 --full-trace dist-esm/test/*.test.js", | ||
"integration-test": "npm run integration-test:node && npm run integration-test:browser", | ||
"lint:fix": "eslint package.json tsconfig.json src test samples --ext .ts --fix --fix-type [problem,suggestion]", | ||
"lint": "eslint package.json tsconfig.json src test samples --ext .ts -f html -o keyvault-keys-lintReport.html || exit 0", | ||
"lint:terminal": "eslint package.json tsconfig.json src test samples --ext .ts", | ||
"prepack": "bash ../prepack.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, this won't work in command prompt on windows, yeah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! This is only a draft. If we end up picking this approach, I can write something on another language (let's say, JavaScript 😋 )
Closing this on favor of: #8866 |
This PR is part of a set of PRs made to explore together what are the possibilities of having, and managing, common code dependencies.
In this specific PR, we'll be exploring how it would be to move the common code out of KeyVault-Keys into a separate folder, bundled together through symbolic links and scripts.
Things to consider:
To do:
Your review is appreciated.