Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the proxyPolicy and constants #6900

Closed
wants to merge 5 commits into from
Closed

Update the proxyPolicy and constants #6900

wants to merge 5 commits into from

Conversation

zzhxiaofeng
Copy link
Contributor

Add the NO_PROXY and ALL_PROXY to constants, and update the proxyPolicy to support env vars for NO_PROXY and ALL_PROXY Azure/azure-sdk-for-java#5967

xirzec
xirzec requested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be confused about how this proxy magic works, but I tried to offer some constructive feedback. 😅

sdk/core/core-http/lib/policies/proxyPolicy.ts Outdated Show resolved Hide resolved
sdk/core/core-http/lib/policies/proxyPolicy.ts Outdated Show resolved Hide resolved
@bterlson
Copy link
Member

Some concerns:

  1. ALL_PROXY doesn't seem super common, so I wonder what the motivation is to support it?
  2. ALL_PROXY seems typically used for SOCKS proxies which, I think, we don't support?
  3. Per guidelines we will have to approve any new environment variable. I've made an issue for it here: Add ALL_PROXY azure-sdk#949.
  4. @xirzec is right about how NO_PROXY should work :)

jongio
jongio requested changes Jan 16, 2020
View reviewed changes
sdk/core/core-http/lib/policies/proxyPolicy.ts Outdated Show resolved Hide resolved
sdk/core/core-http/lib/policies/proxyPolicy.ts Outdated Show resolved Hide resolved
@jongio
Copy link
Member

jongio commented Jan 16, 2020

@schaabs For comments on ALL_PROXY support. See @bterlson comment.

@zzhxiaofeng
Copy link
Contributor Author

Sorry, the old fork is deleted. Please see new PR: #7069

@jongio
Copy link
Member

jongio commented Jan 22, 2020

@zzhxiaofeng Okay to close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongio jongio jongio requested changes

@xirzec xirzec xirzec requested changes

@bterlson bterlson Awaiting requested review from bterlson

@daviwil daviwil Awaiting requested review from daviwil

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzhxiaofeng @bterlson @jongio @xirzec