Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage][Blob] Default values for uploadStream parameters #5740

Merged
merged 4 commits into from
Oct 25, 2019
Merged

[Storage][Blob] Default values for uploadStream parameters #5740

merged 4 commits into from
Oct 25, 2019

Conversation

joheredi
Copy link
Member

Setting renaming parameter max maxBuffers to maxConcurrency and add default parameters for BlockBlobClient.uploadStream:
bufferSize = 8MB and maxConcurrency = 5

Fixes #5456

@joheredi joheredi requested a review from ramya-rao-a October 23, 2019 17:23
@joheredi joheredi added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 23, 2019
@joheredi
Copy link
Member Author

/azp run js - storage-blob - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jiacfan
Copy link
Member

jiacfan commented Oct 24, 2019 

    // concurrency should set a smaller value than maxBuffers, which is helpful to

Please update the comments with reasonable words as well.

Refers to: sdk/storage/storage-blob/src/BlockBlobClient.ts:1148 in 0d6633d. [](commit_id = 0d6633d, deletion_comment = False)

@ramya-rao-a ramya-rao-a merged commit 76b1452 into Azure:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacfan jiacfan jiacfan left review comments

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@HarshaNalluru HarshaNalluru HarshaNalluru approved these changes

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@bterlson bterlson bterlson approved these changes

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

@vinjiang vinjiang Awaiting requested review from vinjiang

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
6 participants
@joheredi @jiacfan @bterlson @XiaoningLiu @HarshaNalluru @ramya-rao-a