[Cosmos] Use local digest instead of crypto-hash #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
commented
Oct 9, 2019
| @@ -0,0 +1,7 @@ | |||
| export function encodeUTF8(str: string): Uint8Array { | |||
There was a problem hiding this comment.
In the future we may want to extract this function to @azure/core-crypto since this overlaps with keyvault
southpolesteve
approved these changes
Oct 10, 2019
|
Approved! Some minimal browser test would be great, but I don't want it to block. We can sort out a browser testing strategy in a different PR. |
I created issue #5506 to enable Browser tests for Cosmos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses problem 1) discussed in #5023, fixing Cosmos in Edge.
This PR is changes the hashing algorithm previously used
SHA1froSHA256which is supported by Edge and all other browsers. Also removing the dependency oncrypto-hash