Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Common Recorder] getUniqueName() - Update the description when same label is used more than once #5351

Merged
merged 1 commit into from
Oct 2, 2019
Merged

[Common Recorder] getUniqueName() - Update the description when same label is used more than once #5351

merged 1 commit into from
Oct 2, 2019

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Oct 2, 2019 •
edited
Loading

Updating the description of getUniqueName() to make the behaviour clear.

@HarshaNalluru HarshaNalluru self-assigned this Oct 2, 2019
jeremymeng
jeremymeng approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HarshaNalluru HarshaNalluru added the Client This issue points to a problem in the data-plane of the library. label Oct 2, 2019
sadasant
sadasant approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@HarshaNalluru HarshaNalluru merged commit c1f17d2 into master Oct 2, 2019
@weshaggard weshaggard deleted the HarshaNalluru-patch-1 branch February 3, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasant sadasant sadasant approved these changes

@jeremymeng jeremymeng jeremymeng approved these changes

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshaNalluru @sadasant @jeremymeng