Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] replace node-abort-controller with @azure/abort-controller #5335

Merged
merged 1 commit into from
Oct 3, 2019
Merged

[Cosmos] replace node-abort-controller with @azure/abort-controller #5335

merged 1 commit into from
Oct 3, 2019

Conversation

joheredi
Copy link
Member

@joheredi joheredi commented Oct 1, 2019

Replacing the use of node-abort-controller and abort-controller with @azure/abort-controller (Fixes #5264)

@joheredi joheredi added Client This issue points to a problem in the data-plane of the library. Cosmos labels Oct 1, 2019
@ramya-rao-a ramya-rao-a requested a review from bterlson October 1, 2019 21:25
Copy link
Member

@bterlson bterlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see the theory that these libraries are compatible proved out!

@HarshaNalluru HarshaNalluru changed the base branch from master to HarshaNalluru-patch-1 October 2, 2019 18:47
@HarshaNalluru HarshaNalluru changed the base branch from HarshaNalluru-patch-1 to master October 2, 2019 18:48
@joheredi joheredi closed this Oct 2, 2019
@joheredi joheredi reopened this Oct 2, 2019
@joheredi joheredi closed this Oct 2, 2019
@joheredi joheredi reopened this Oct 2, 2019
@azure-pipelines
Copy link

Azure Pipelines successfully started running 30 pipeline(s), but failed to run 1 pipeline(s).

@joheredi joheredi merged commit eed5c32 into Azure:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cosmos] Replace node-abort-controller with @azure/abort-controller
5 participants