[Storage] Samples - Get account name, key, sas from environment if present #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
jeremymeng,
jiacfan,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
changed the title
HarshaNalluru
added
Client
HarshaNalluru
changed the title
jeremymeng
reviewed
Oct 2, 2019
| const localFilePath = ""; | ||
| const account = process.env.ACCOUNT_NAME || ""; | ||
| const accountSas = process.env.ACCOUNT_SAS || ""; | ||
| const localFilePath = "../README.md"; |
There was a problem hiding this comment.
nit: could upload the source code file itself?
There was a problem hiding this comment.
Which source code file?
There was a problem hiding this comment.
sample file names may change, readme will be present forever.
There was a problem hiding this comment.
fair, I was thinking there could be folder changes. This is good to merge.
jeremymeng
approved these changes
Oct 2, 2019
|
As long as we have an easy way for users to paste in things instead of having to set environment variables it is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4906 and #3450 partially.