[Common Recorder] Updated README #5288
Conversation
sdk/test-utils/recorder/README.md
Outdated
| `@azure/keyvault/keyvault-keys` repository). It must be used inside of Mocha's | ||
| tests, since it uses [nise](https://www.npmjs.com/package/nise) under the hood. | ||
| It also returns an object with a method `stop()`, which will allow you to control when | ||
| you want the recorder to stop re-routing your http requests. |
There was a problem hiding this comment.
Add link for more detailed description?
https://github.com/Azure/azure-sdk-for-js/blame/master/sdk/test-utils/recorder/GUIDELINES.md#L79
There was a problem hiding this comment.
getUniqueName and newDate are not part of src/index.ts though! Should we make an issue?
There was a problem hiding this comment.
They are part of the Recorder interface that is being exported in the src/index.ts file.
record(this) is invoked in the beforeEach section.
record(this) returns the Recorder interface which has a bunch of functions attached to it.
stop, skip, getUniqueName, newDate
There was a problem hiding this comment.
Great job, @sadasant !!! 🤩
I could only review half of the document, I'll take some time to review it completely. 🥱
sadasant
force-pushed
the
feature/fix4961
branch
from
781a171 to
abea651
Compare
sadasant
force-pushed
the
feature/fix4961
branch
from
abea651 to
5175145
Compare
sadasant
force-pushed
the
feature/fix4961
branch
from
4bb817e to
12b6598
Compare
This is just a proposal! Let's review it and make it better together <3
Fixes #4961