Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Get proxySettings from Environment when not defined in the code #5230

Merged
merged 3 commits into from
Sep 24, 2019
Merged

[Storage] Get proxySettings from Environment when not defined in the code #5230

merged 3 commits into from
Sep 24, 2019

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Sep 23, 2019 •
edited
Loading

When pipelineOptions.proxy is undefined, getDefaultProxySettings() in core-http tries to load the proxy settings from the environment

(Example - process.env.HTTP_PROXY = "http://127.0.0.1:8888"; can be set)

jeremymeng
jeremymeng approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Sep 23, 2019
@HarshaNalluru HarshaNalluru self-assigned this Sep 23, 2019
XiaoningLiu
XiaoningLiu approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@XiaoningLiu XiaoningLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HarshaNalluru HarshaNalluru merged commit 30274c5 into Azure:feature/storage Sep 24, 2019
@kurtzeborn kurtzeborn mentioned this pull request Sep 24, 2019
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@XiaoningLiu XiaoningLiu XiaoningLiu approved these changes

@jiacfan jiacfan Awaiting requested review from jiacfan

@vinjiang vinjiang Awaiting requested review from vinjiang

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarshaNalluru @XiaoningLiu @jeremymeng