[Event Hubs] Use namespace in Partition Manager to guarantee uniqueness #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivangiReja
added
Client
ShivangiReja
requested review from
srnagar,
conniey,
YijunXieMS,
kinelski and
jsquire
ramya-rao-a
reviewed
Sep 17, 2019
…to pr/ShivangiReja/5153-1
chradek
reviewed
Sep 17, 2019
There was a problem hiding this comment.
Can you also add tests for EventHubClient that verifies we can get the fully qualified namespace when we instantiate the client using a connection string, and when we use credentials from identity?
Also, please update the changelogs since there are user-facing changes here :)
ramya-rao-a
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, the Partition Manager takes the event hub name, consumer group name and partition id to ensure uniqueness for the checkpoint and ownership. Since the same event hub name and consumer group name can exist in another namespace, we need to use the namespace as well to ensure uniqueness.