Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[app-configuration] Adding in sample code and readme #5091
[app-configuration] Adding in sample code and readme #5091
Changes from 11 commits
a8563e5
4d28f3c
e146b60
67407a6
c0e9fc8
5bafe08
32c2677
a046aa0
dfe71ef
31be815
3691bc3
49be1aa
18831bd
bdf5273
cbd0a82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're using await, you can rewrite this as
You should also give an explanation of what some of the fields are...just looking at it I'm not sure what
acceptDateTime
is doing, or what specifyingfields
will do either.Nit: I don't think top-level await exists yet, you'd need to use await inside of an async function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified it to e a simpler API that basically does the same thing. The listConfigurationSetting() api is a bit more complex and could use a better sample which I can add in another PR.