Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies to latest #5072

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Update dependencies to latest #5072

merged 1 commit into from
Sep 13, 2019

Conversation

mikeharder
Copy link
Member

  • Add package-lock.json for repeatable builds
  • Pin preview versions since there may be breaking changes between previews
  • Add *.js and *.js.map to .gitignore (files are generated by tsc)

@mikeharder
Copy link
Member Author

/azp run js - smoke-tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@danieljurek
Copy link
Member

/azp run js - smoke-tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

danieljurek
danieljurek approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Smoke Tests have passed. Holding on merge until we ship.

The addition of the package-lock.json file here is to ensure that the build is repeatable.

@danieljurek
Copy link
Member

Preview has shipped. Merging this now. Another PR will handle updating to the current preview.

@danieljurek danieljurek merged commit 89dfa44 into Azure:master Sep 13, 2019
@mikeharder mikeharder deleted the update-smoke-test-dependencies branch November 5, 2019 17:30
@Randyblo7 Randyblo7 mentioned this pull request Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljurek danieljurek danieljurek approved these changes

Assignees

@danieljurek danieljurek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeharder @danieljurek