-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs] Enable runtime metrics feature #5036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Sep 6, 2019
@@ -280,6 +279,14 @@ export class ReceiveHandler { | |||
stop(): Promise<void>; | |||
} | |||
|
|||
// @public | |||
export interface ReceiverRuntimeInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name should be LastEnqueuedEventInfo
The properties on it can be
- offset
- sequenceNumber
- enqueuedTime
- retrievalTime
ramya-rao-a
reviewed
Sep 6, 2019
chradek
reviewed
Sep 6, 2019
chradek
reviewed
Sep 6, 2019
chradek
approved these changes
Sep 6, 2019
ramya-rao-a
approved these changes
Sep 6, 2019
This was referenced Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of these changes is to reintroduce the concept of partition metrics associated with an EventHubConsumer and piggy-backing on received events. These metrics allow library consumers the opportunity for real-time inspection of the event processing backlog without the need to make dedicated requests for partition information.