Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-datafactory] support dataset v2 split name #4451

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/datafactory/arm-datafactory/LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018 Microsoft
Copyright (c) 2019 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
17 changes: 8 additions & 9 deletions sdk/datafactory/arm-datafactory/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This package contains an isomorphic SDK for DataFactoryManagementClient.

### How to Install

```
```bash
npm install @azure/arm-datafactory
```

Expand All @@ -19,15 +19,15 @@ npm install @azure/arm-datafactory

##### Install @azure/ms-rest-nodeauth

```
```bash
npm install @azure/ms-rest-nodeauth
```

##### Sample code

```ts
import * as msRest from "@azure/ms-rest-js";
import * as msRestAzure from "@azure/ms-rest-azure-js";
```typescript
import * as coreHttp from "@azure/core-http";
import * as coreArm from "@azure/core-arm";
import * as msRestNodeAuth from "@azure/ms-rest-nodeauth";
import { DataFactoryManagementClient, DataFactoryManagementModels, DataFactoryManagementMappers } from "@azure/arm-datafactory";
const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
Expand All @@ -47,7 +47,7 @@ msRestNodeAuth.interactiveLogin().then((creds) => {

##### Install @azure/ms-rest-browserauth

```
```bash
npm install @azure/ms-rest-browserauth
```

Expand All @@ -61,8 +61,8 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to
<html lang="en">
<head>
<title>@azure/arm-datafactory sample</title>
<script src="node_modules/@azure/ms-rest-js/dist/msRest.browser.js"></script>
<script src="node_modules/@azure/ms-rest-azure-js/dist/msRestAzure.js"></script>
<script src="node_modules/@azure/core-http/dist/coreHttp.browser.js"></script>
<script src="node_modules/@azure/core-arm/dist/coreArm.js"></script>
<script src="node_modules/@azure/ms-rest-browserauth/dist/msAuth.js"></script>
<script src="node_modules/@azure/arm-datafactory/dist/arm-datafactory.js"></script>
<script type="text/javascript">
Expand Down Expand Up @@ -95,5 +95,4 @@ See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to

- [Microsoft Azure SDK for Javascript](https://github.com/Azure/azure-sdk-for-js)


![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js/sdk/datafactory/arm-datafactory/README.png)
14 changes: 8 additions & 6 deletions sdk/datafactory/arm-datafactory/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "DataFactoryManagementClient Library with typescript type definitions for node.js and browser.",
"version": "5.3.0",
"dependencies": {
"@azure/ms-rest-azure-js": "^1.1.0",
"@azure/ms-rest-js": "^1.1.0",
"@azure/core-arm": "^1.0.0-preview.1",
"@azure/core-http": "^1.0.0-preview.1",
"tslib": "^1.9.3"
},
"keywords": [
Expand All @@ -23,15 +23,16 @@
"typescript": "^3.1.1",
"rollup": "^0.66.2",
"rollup-plugin-node-resolve": "^3.4.0",
"rollup-plugin-sourcemaps": "^0.4.2",
"uglify-js": "^3.4.9"
},
"homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/sdk/datafactory/arm-datafactory",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/datafactory/arm-datafactory",
"repository": {
"type": "git",
"url": "https://github.com/azure/azure-sdk-for-js.git"
"url": "https://github.com/Azure/azure-sdk-for-js.git"
},
"bugs": {
"url": "https://github.com/azure/azure-sdk-for-js/issues"
"url": "https://github.com/Azure/azure-sdk-for-js/issues"
},
"files": [
"dist/**/*.js",
Expand All @@ -43,6 +44,7 @@
"esm/**/*.d.ts",
"esm/**/*.d.ts.map",
"src/**/*.ts",
"README.md",
"rollup.config.js",
"tsconfig.json"
],
Expand All @@ -52,5 +54,5 @@
"prepack": "npm install && npm run build"
},
"sideEffects": false,
"authPublish": true
"autoPublish": true
}
26 changes: 16 additions & 10 deletions sdk/datafactory/arm-datafactory/rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,31 +1,37 @@
import rollup from "rollup";
import nodeResolve from "rollup-plugin-node-resolve";
import sourcemaps from "rollup-plugin-sourcemaps";

/**
* @type {import('rollup').RollupFileOptions}
* @type {rollup.RollupFileOptions}
*/
const config = {
input: './esm/dataFactoryManagementClient.js',
external: ["@azure/ms-rest-js", "@azure/ms-rest-azure-js"],
input: "./esm/dataFactoryManagementClient.js",
external: [
"@azure/core-http",
"@azure/core-arm"
],
output: {
file: "./dist/arm-datafactory.js",
format: "umd",
name: "Azure.ArmDatafactory",
sourcemap: true,
globals: {
"@azure/ms-rest-js": "msRest",
"@azure/ms-rest-azure-js": "msRestAzure"
"@azure/core-http": "coreHttp",
"@azure/core-arm": "coreArm"
},
banner: `/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Licensed under the MIT License. See License.txt in the project root for license information.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
* regenerated.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/`
},
plugins: [
nodeResolve({ module: true })
nodeResolve({ module: true }),
sourcemaps()
]
};

export default config;
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* regenerated.
*/

import * as msRest from "@azure/ms-rest-js";
import * as coreHttp from "@azure/core-http";
import * as Models from "./models";
import * as Mappers from "./models/mappers";
import * as operations from "./operations";
Expand All @@ -19,7 +19,9 @@ class DataFactoryManagementClient extends DataFactoryManagementClientContext {
// Operation groups
operations: operations.Operations;
factories: operations.Factories;
exposureControl: operations.ExposureControl;
integrationRuntimes: operations.IntegrationRuntimes;
integrationRuntimeObjectMetadata: operations.IntegrationRuntimeObjectMetadata;
integrationRuntimeNodes: operations.IntegrationRuntimeNodes;
linkedServices: operations.LinkedServices;
datasets: operations.Datasets;
Expand All @@ -36,11 +38,13 @@ class DataFactoryManagementClient extends DataFactoryManagementClientContext {
* @param subscriptionId The subscription identifier.
* @param [options] The parameter options
*/
constructor(credentials: msRest.ServiceClientCredentials, subscriptionId: string, options?: Models.DataFactoryManagementClientOptions) {
constructor(credentials: coreHttp.TokenCredential | coreHttp.ServiceClientCredentials, subscriptionId: string, options?: Models.DataFactoryManagementClientOptions) {
super(credentials, subscriptionId, options);
this.operations = new operations.Operations(this);
this.factories = new operations.Factories(this);
this.exposureControl = new operations.ExposureControl(this);
this.integrationRuntimes = new operations.IntegrationRuntimes(this);
this.integrationRuntimeObjectMetadata = new operations.IntegrationRuntimeObjectMetadata(this);
this.integrationRuntimeNodes = new operations.IntegrationRuntimeNodes(this);
this.linkedServices = new operations.LinkedServices(this);
this.datasets = new operations.Datasets(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
*/

import * as Models from "./models";
import * as msRest from "@azure/ms-rest-js";
import * as msRestAzure from "@azure/ms-rest-azure-js";
import * as coreHttp from "@azure/core-http";
import * as coreArm from "@azure/core-arm";

const packageName = "@azure/arm-datafactory";
const packageVersion = "0.1.0";
const packageVersion = "5.3.0";

export class DataFactoryManagementClientContext extends msRestAzure.AzureServiceClient {
credentials: msRest.ServiceClientCredentials;
export class DataFactoryManagementClientContext extends coreArm.AzureServiceClient {
credentials: coreHttp.TokenCredential | coreHttp.ServiceClientCredentials;
subscriptionId: string;
apiVersion?: string;

Expand All @@ -26,7 +26,7 @@ export class DataFactoryManagementClientContext extends msRestAzure.AzureService
* @param subscriptionId The subscription identifier.
* @param [options] The parameter options
*/
constructor(credentials: msRest.ServiceClientCredentials, subscriptionId: string, options?: Models.DataFactoryManagementClientOptions) {
constructor(credentials: coreHttp.TokenCredential | coreHttp.ServiceClientCredentials, subscriptionId: string, options?: Models.DataFactoryManagementClientOptions) {
if (credentials == undefined) {
throw new Error('\'credentials\' cannot be null.');
}
Expand All @@ -38,7 +38,7 @@ export class DataFactoryManagementClientContext extends msRestAzure.AzureService
options = {};
}
if(!options.userAgent) {
const defaultUserAgent = msRestAzure.getDefaultUserAgentValue();
const defaultUserAgent = coreArm.getDefaultUserAgentValue();
options.userAgent = `${packageName}/${packageVersion} ${defaultUserAgent}`;
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,17 @@
/*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
* Licensed under the MIT License. See License.txt in the project root for license information.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
* regenerated.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

export {
discriminators,
ActivityRun,
ActivityRunsQueryResponse,
CloudError,
RunFilterParameters,
RunQueryFilter,
RunQueryOrderBy,
ActivityRunsQueryResponse,
ActivityRun,
CloudError
RunQueryOrderBy
} from "../models/mappers";

Loading