Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPH] Update expected user agent in tests #4444

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder requested a review from ShivangiReja July 26, 2019 00:54
@mikeharder
Copy link
Member Author

/azp run js - eventhubs-processor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder
Copy link
Member Author

@shivangi: I think this PR should be merged as-is to unblock tests, but this code should later be improved by extracting the constant into a separate file like already done in event-hubs:

export const packageJsonInfo = {

const userAgent: string = `azsdk-js-azureeventhubs/${packageJsonInfo.version} (NODE-VERSION ${

properties!["user-agent"].should.startWith(`azsdk-js-azureeventhubs/${packageVersion}`);

@mikeharder mikeharder requested a review from chradek as a code owner July 26, 2019 01:30
@mikeharder
Copy link
Member Author

/azp run js - eventhubs-processor - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder mikeharder merged commit a999bfc into Azure:master Jul 26, 2019
@mikeharder mikeharder deleted the eph-test-user-agent branch July 26, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants