Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust timeout for lock renewal related tests #3928

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

ramya0820
Copy link
Member

@ramya0820 ramya0820 commented Jun 18, 2019

This PR is to fix few of the lesser occurring test failures on CI.
Specifically, since ones related to lock renewal (non-sessions) all take time 85 - 92 seconds and the timeout is at 90s, the CI logs some of these as timeout failures.

@ramya0820 ramya0820 requested a review from ramya-rao-a June 18, 2019 22:29
@ramya0820 ramya0820 self-assigned this Jun 18, 2019
@ramya0820 ramya0820 changed the title Adjust renewLock timeout Adjust timeout for lock renewal related tests Jun 18, 2019
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't we need a similar change to the "sessions" versions of these tests?

@ramya0820
Copy link
Member Author

won't we need a similar change to the "sessions" versions of these tests?

Yes, I had checked - they are already updated to be 95s and don't seem to require an update (no such failures on CI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants