-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ai] Precise Typechecking #32149
Merged
Merged
[ai] Precise Typechecking #32149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
a team,
bterlson,
KarishmaGhiya,
jeremymeng,
rhurey,
dargilco,
glharper,
jhakulin,
quentinRobinson,
joheredi and
xirzec
as code owners
December 10, 2024 22:30
API change check API changes are not detected in this pull request. |
jeremymeng
reviewed
Dec 11, 2024
sdk/documentintelligence/ai-document-intelligence-rest/samples-dev/composeModel.ts
Outdated
Show resolved
Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/test/public/training.spec.ts
Outdated
Show resolved
Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/test/public/training.spec.ts
Outdated
Show resolved
Hide resolved
…blic/training.spec.ts Co-authored-by: Jeremy Meng <[email protected]>
jeremymeng
approved these changes
Dec 11, 2024
HarshaNalluru
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form-recognizer and document-intelligence are good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
N/A
Describe the problem that is addressed by this PR
Tests are not being typechecked and linting isn't configured correctly. This PR migrates those libraries to precise typechecking setup introduced in #31786
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
#31786
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists