Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai] Precise Typechecking #32149

Merged
merged 12 commits into from
Dec 11, 2024
Merged

[ai] Precise Typechecking #32149

merged 12 commits into from
Dec 11, 2024

Conversation

deyaaeldeen
Copy link
Member

Packages impacted by this PR

  • @azure-rest/ai-inference
  • @azure-rest/ai-content-safety
  • @azure-rest/ai-language-textauthoring
  • @azure-rest/ai-document-intelligence
  • @azure-rest/ai-document-translator
  • @azure-rest/ai-vision-face
  • @azure-rest/ai-vision-image-analysis
  • @azure-rest/ai-translation-text
  • @azure/ai-language-conversations
  • @azure/ai-language-text
  • @azure/ai-metrics-advisor
  • @azure/ai-text-analytics

Issues associated with this PR

N/A

Describe the problem that is addressed by this PR

Tests are not being typechecked and linting isn't configured correctly. This PR migrates those libraries to precise typechecking setup introduced in #31786

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

N/A

Provide a list of related PRs (if any)

#31786

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@deyaaeldeen deyaaeldeen requested a review from ckairen as a code owner December 11, 2024 00:03
@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 11, 2024

API change check

API changes are not detected in this pull request.

Copy link
Member

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form-recognizer and document-intelligence are good.

@deyaaeldeen deyaaeldeen merged commit f30dba0 into main Dec 11, 2024
19 checks passed
@deyaaeldeen deyaaeldeen deleted the ai-precise-checking branch December 11, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants