-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Fix monitor-opentelemetry-exporter live tests #31675
[Test] Fix monitor-opentelemetry-exporter live tests #31675
Conversation
Migrate the non-standard tests
/azp run js - monitor-opentelemetry-exporter - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
API change check API changes are not detected in this pull request. |
/azp run js - monitor-opentelemetry-exporter - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks that the tests are being executed now. However, the tests are now failing. It looks like a test issue to me. Previously they were passing because the test catches error and calls - it("should work", (done) => {
- scenario
- .run()
- .then(() => {
- // promisify doesn't work on this, so use callbacks/done for now
- // eslint-disable-next-line promise/always-return
- return scenario.flush().then(() => {
- assertMetricExpectation(ingest, scenario.expectation);
- assertCount(ingest, scenario.expectation);
- done();
- });
- })
- .catch((e) => {
- done(e);
- });
+ it("should work", async () => {
+ await scenario.run();
+ // promisify doesn't work on this, so use callbacks/done for now
+ // eslint-disable-next-line promise/always-return
+ await scenario.flush();
+ assertMetricExpectation(ingest, scenario.expectation);
+ assertCount(ingest, scenario.expectation);
});
|
/check-enforcer override |
Migrate the non-standard tests