Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CODEOWNERS] update rush.json and ignore-links.txt owners #30457

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Jul 18, 2024

to js team because we need to add projects for management packages and ignore links to documents that are not ready yet.

also remove /**/tsconfig.strict.json entry. It was added for we did migration work for cosmos but we shouldn't own it any more.

to js team because we need to add projects for management packages and ignore
links to documents that are not ready yet.

also remove `/**/tsconfig.strict.json` entry. It was added for linting work but
no longer applies
@jeremymeng jeremymeng requested a review from xirzec July 18, 2024 14:17
@jeremymeng jeremymeng merged commit 8fc6a67 into Azure:main Jul 19, 2024
5 checks passed
@jeremymeng jeremymeng deleted the owners/rushjson branch July 19, 2024 14:41
/tsconfig.json @mikeharder @ckairen @jeremymeng @deyaaeldeen
/**/tsconfig.json @jeremymeng @deyaaeldeen
/**/tsconfig.strict.json @deyaaeldeen
/**/tsconfig.json @jeremymeng @deyaaeldeen @Azure/azure-sdk-for-js-core
Copy link
Member

@MaryGao MaryGao Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremymeng it seems this still blocked us?
#30341

image

Copy link
Member Author

@jeremymeng jeremymeng Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah I will need an entry for mgmt path I guess, similar to the api.md one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants