Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure/eventgrid] Fix Timestamp deserialization #30399

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

sarangan12
Copy link
Member

Packages impacted by this PR

@azure/eventgrid

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

Fix Timestamp deserialization

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

No special design considerations

Are there test cases added in this PR? (If not, why?)

No

Provide a list of related PRs (if any)

Azure/azure-sdk-for-net#44982

Command used to generate this PR:**(Applicable only to SDK release request PRs)

autorest --typescript swagger\README.md

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@sarangan12 sarangan12 requested review from bterlson and a team as code owners July 15, 2024 18:25
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/eventgrid-system-events

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/eventgrid-system-events

Copy link
Member

@maorleger maorleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to understand the move from unknown to any here - the rationale and any previous discussions around this would be very helpful

@sarangan12 sarangan12 enabled auto-merge (squash) July 16, 2024 00:19
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. I also felt that unknown is better than any even with a cost.

@sarangan12 sarangan12 merged commit c8b33a3 into Azure:main Jul 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants