-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@azure/eventgrid] Fix Timestamp deserialization #30399
Conversation
API change check API changes are not detected in this pull request. |
API change check API changes are not detected in this pull request. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
API change check API changes are not detected in this pull request. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to understand the move from unknown
to any
here - the rationale and any previous discussions around this would be very helpful
sdk/eventgrid/eventgrid-system-events/review/eventgrid-system-events.api.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me. I also felt that unknown
is better than any
even with a cost.
Packages impacted by this PR
@azure/eventgrid
Issues associated with this PR
NA
Describe the problem that is addressed by this PR
Fix Timestamp deserialization
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
No special design considerations
Are there test cases added in this PR? (If not, why?)
No
Provide a list of related PRs (if any)
Azure/azure-sdk-for-net#44982
Command used to generate this PR:**(Applicable only to SDK release request PRs)
autorest --typescript swagger\README.md
Checklists