Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rush update --full and testing #29471 #29655

Merged
merged 38 commits into from
May 14, 2024

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented May 9, 2024

What's happening?

  • Get Scott's test-proxy version from Use Common Sanitizers #29471
  • Update recorder 3.5.0 with
    • Central Sanitizers
    • /removeSanitizers API
    • remove fallback sanitizers
    • Publish recorder 3.5.0
  • Update recorder 4.x with the recorder 3.5.0 changes and make sure they are in sync.
  • Update lock file with rush update --full to get latest recorder and test-credential packages
  • Test/fix packages
    • recorder
    • storage
    • template
    • '@azure-rest/synapse-access-control'
    • '@azure/arm-resources'
    • arm-links
    • arm-resources
    • event-grid
    • template-dpg
    • synpase packages
    • '@azure/identity' (future PR)
    • '@azure/arm-eventgrid'
    • '@azure/ai-text-analytics'

Future Work

  • Figure out identity tests/recordings
  • Make sure CI pipelines for each of the services that are not triggered in this PR get to green by either re-recording or tweaking the recorder config for the package

@HarshaNalluru HarshaNalluru changed the title Update lock file to get latest test-recorder and test-credential packages rush update --full and testing #29471 May 9, 2024
@HarshaNalluru
Copy link
Member Author

/azp run js - storage - ci

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@HarshaNalluru
Copy link
Member Author

https://dev.azure.com/azure-sdk/public/_build/results?buildId=3776354&view=results

@HarshaNalluru
Copy link
Member Author

/azp run js - appconfiguration - ci

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@HarshaNalluru HarshaNalluru requested a review from timovv as a code owner May 10, 2024 07:07
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

1 similar comment
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@@ -66,7 +66,7 @@
"test:node": "npm run clean && npm run unit-test:node && npm run integration-test:node",
"test": "npm run clean && npm run build:test && npm run unit-test && npm run integration-test",
"unit-test:browser": "dev-tool run test:browser",
"unit-test:node": "dev-tool run test:node-ts-input -- --timeout 300000 --exclude 'test/**/browser/**/*.spec.ts' 'test/**/**/*.spec.ts'",
"unit-test:node": "echo skipped",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish to handle identity in a follow up PR as it is uncertain on recording with various credentials

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -27,7 +27,8 @@ const replaceableVariables: Record<string, string> = {
};

const recorderOptions: RecorderStartOptions = {
envSetupForPlayback: replaceableVariables
envSetupForPlayback: replaceableVariables,
removeCentralSanitizers: ["AZSDK3493"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there docs on when and what sanitizers people need to remove?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw in some packages like storage-blob, there is a comment on why we don't need the x-ms-encryption-key-sha256 sanitizer. I'd love to have this guideline too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott is working on the docs Azure/azure-sdk-tools#8142

I've added comments for all the current usages.

@HarshaNalluru HarshaNalluru merged commit 2b71281 into Azure:main May 14, 2024
94 checks passed
@HarshaNalluru HarshaNalluru deleted the harshan/rush-update-full branch May 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants