Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Document Intelligence] Typespec Generated Code #27516

Merged
merged 56 commits into from
Nov 16, 2023
Merged

[Document Intelligence] Typespec Generated Code #27516

merged 56 commits into from
Nov 16, 2023

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Oct 23, 2023 •
edited
Loading

This PR

  • Code generated from Typespec
  • Changelog
  • Port all the Tests from FR
  • Push recordings to assets repo
  • Samples-dev, JS, and TS
  • Readme
  • Readme getting started samples
  • Sample.env
  • CI
  • Live test pipeline
  • test-resources.json

Future PR

  • Browser tests
  • AAD (service doesn't support yet for this preview)
  • Add back API REF link
  • Migration Guide

Typespec / Code generation feedback

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 23, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-rest-ai-document-intelligence

@HarshaNalluru
first draft of generated code using typespec
07d4dc3
@HarshaNalluru
build conflicts
d451e2a
@HarshaNalluru
manual updates on geenrated code to fix build - build is green now
1f2f6fe
@HarshaNalluru
4 functional live tests
4261e58
@HarshaNalluru
rushx format
f8eb647
@HarshaNalluru
concise
090d7be
@HarshaNalluru
remove typespec references
f1118b2
@HarshaNalluru
with latest typespec from Paul
5d003e1
@HarshaNalluru
ignore typespec files
350c05a
@HarshaNalluru
build test
ab6892b
@HarshaNalluru
latest generated code Nov 2nd
38febeb
@HarshaNalluru
fix policy addition
b1d6a5e
@HarshaNalluru
test files
4cc6f60
@HarshaNalluru
rename package and build
65216ea
@HarshaNalluru
latest typespec, build and format
dc16243
@HarshaNalluru
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…
516e02b 
… harshan/typespec-fr
@HarshaNalluru
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…
ab5d36a 
… harshan/typespec-fr
@HarshaNalluru
lock file from main
0ef1f0c
@HarshaNalluru
lock file
bef1b6a
@HarshaNalluru
tests and sample
8559979
jeremymeng
jeremymeng approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor comments

sdk/documentintelligence/ai-document-intelligence-rest/README.md Outdated Show resolved Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/package.json Outdated Show resolved Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/package.json Outdated Show resolved Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/package.json Outdated Show resolved Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/review/document-intelligence.api.md Outdated Show resolved Hide resolved
sdk/documentintelligence/ai-document-intelligence-rest/sample.md Outdated Show resolved Hide resolved
@HarshaNalluru
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru
Copy link
Member Author

/azp run js - ai-document-intelligence - ci

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@HarshaNalluru
Copy link
Member Author

/azp run js - documentintelligence - ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@HarshaNalluru HarshaNalluru mentioned this pull request Nov 16, 2023
Open
@HarshaNalluru HarshaNalluru mentioned this pull request Nov 16, 2023
Open
@HarshaNalluru
Copy link
Member Author

Live test pipeline https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3269699&view=results is green 💚

@HarshaNalluru HarshaNalluru enabled auto-merge (squash) November 16, 2023 23:09
@HarshaNalluru HarshaNalluru merged commit 642530f into Azure:main Nov 16, 2023
22 checks passed
@HarshaNalluru HarshaNalluru deleted the harshan/typespec-fr branch November 16, 2023 23:38
This was referenced Nov 17, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@jeremymeng jeremymeng jeremymeng approved these changes

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen deyaaeldeen is a code owner

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@ckairen ckairen Awaiting requested review from ckairen ckairen is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees
No one assigned
Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HarshaNalluru @azure-sdk @jeremymeng @MaryGao