Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job router rest client library #27325

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Conversation

marche0133
Copy link
Member

JobRouter js sdk for GA

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@marche0133
Copy link
Member Author

marche0133 commented Oct 4, 2023

Hi @jeremymeng , can you help review and approve this PR? it is new jobrouter rest library for GA.

we need this to merge in main for API Review.

samples/tests/readme will be updated later

Copy link
Member

@adamtuck-msft adamtuck-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is communication-job-router-rest the new home for the SDK? Or is that temporary as we transition to the TypeSpec generated SDK.

@marche0133
Copy link
Member Author

Is communication-job-router-rest the new home for the SDK? Or is that temporary as we transition to the TypeSpec generated SDK.

It is the home for the new sdk, the package name is also new @azure-rest/communication-job-router

@marche0133 marche0133 merged commit 4359523 into main Oct 6, 2023
@marche0133 marche0133 deleted the marc/jobrouter-rest-V2023-11-01 branch October 6, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants