[engsys] build test assets only for browser runs #27035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer run Node tests against bundled tests. The test inputs are from dist-esm/test and running `build` produces the same output as `build:test` as far as Node is concerned. For browser we still need the bundled tests from `build:test`. This PR enable "Build test assets" step only if the run is for browser.
|
/azp run js - storage-blob - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - app-configuration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeremymeng
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
benbp
reviewed
Sep 7, 2023
benbp
reviewed
Sep 7, 2023
benbp
approved these changes
Sep 7, 2023
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Sep 8, 2023
This reverts commit e453c2d.
jeremymeng
added a commit
that referenced
this pull request
Sep 11, 2023
…27065) This reverts commit e453c2d. PR #27035 keeps `build;test` only for browser runs. It turns out that a couple of packages have custom `build:test` scripts that are different from `build`. While we can explore more on enabling `build:test` for these few packages, this PR reverts the changes to unblock automation builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer run Node tests against bundled tests. The test inputs are from dist-esm/test and running
buildproduces the same output asbuild:testas far as Node is concerned.For browser we still need the bundled tests from
build:test.This PR enables "Build test assets" step only if the run is for browser.