-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design review for multi-client and multi-endpoint in modular #26164
Merged
qiaozha
merged 35 commits into
Azure:main
from
qiaozha:design-review-for-multi-client-and-multi-api-in-modular
Jul 25, 2023
Merged
Design review for multi-client and multi-endpoint in modular #26164
qiaozha
merged 35 commits into
Azure:main
from
qiaozha:design-review-for-multi-client-and-multi-api-in-modular
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
bterlson,
mpodwysocki,
joheredi,
jeremymeng and
witemple-msft
as code owners
June 14, 2023 11:39
qiaozha
changed the title
Design review for multi client and multi api in modular
Design review for multi-client and multi-endpoint in modular
Jun 17, 2023
MaryGao
reviewed
Jun 27, 2023
mpodwysocki
approved these changes
Jul 5, 2023
/check-enforcer override |
joheredi
reviewed
Jul 25, 2023
joheredi
approved these changes
Jul 25, 2023
/check-enforcer override |
qiaozha
deleted the
design-review-for-multi-client-and-multi-api-in-modular
branch
July 25, 2023 03:12
MaryGao
reviewed
Jul 25, 2023
dgetu
pushed a commit
that referenced
this pull request
Sep 6, 2023
In this design doc, we will mainly review how the multi-client libraries and multi-endpoint libraries look like in our JS modular.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this design doc, we will mainly review how the multi-client libraries and multi-endpoint libraries look like in our JS modular.