Add support for invalid char in file #24759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaZhu
requested review from
XiaoningLiu,
jeremymeng,
vinjiang,
jiacfan and
ljian3377
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
|
@EmmaZhu I'd thought that we fixed the issue in codegen and core to support |
EmmaZhu
force-pushed
the
storage/file_invalid_char
branch
2 times, most recently
from
118dc1d to
9aec67a
Compare
|
@jeremymeng , the content and attribute is passed from XML correctly. This PR is to decode the directory name or file name from the passed content. This way the input file name would be the same with the one gotten from listing. |
blueww
approved these changes
Feb 8, 2023
EmmaZhu
force-pushed
the
storage/file_invalid_char
branch
from
9aec67a to
d030630
Compare
EmmaZhu
force-pushed
the
storage/file_invalid_char
branch
from
d030630 to
df4c1a8
Compare
|
@EmmaZhu got it. thanks for the explanation! |
jeremymeng
pushed a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Feb 8, 2023
Add support for file invalid char
18 tasks
jeremymeng
added a commit
to jeremymeng/azure-sdk-for-js
that referenced
this pull request
Jun 13, 2023
- port tests - use isBrowser from core-util
jeremymeng
added a commit
that referenced
this pull request
Jun 19, 2023
- port tests - use isBrowser from core-util - port the source changes - re-generate client - update test resource names to use different variable names. New recorder unique names are slightly different from previous version and cause same name to be retrieved for "dir" variable. - add recordings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for file invalid char