[dev-tool] try / and \ path separators when checking bundling warnings
#24386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nings
It turns out that on windows some warnings are reported with `\` separator while
others with `/` at the same time, e.g.,
str ../../../common/temp/node_modules/.pnpm/[email protected]/node_modules/chai/lib/chai.js
str C:\github\jeremymeng\js-master\common\temp\node_modules\.pnpm\[email protected]\node_modules\sinon\pkg\sinon-esm.js
This PR changes to try both separators when checking whether to suppress bundle warnings.
jeremymeng
requested review from
mikeharder,
ckairen,
witemple-msft and
deyaaeldeen
as code owners
ghost
added
the
witemple-msft
approved these changes
Feb 24, 2023
Co-authored-by: Will Temple <[email protected]>
maybe underlying package to resolve paths has a bug on windows? It's also strange to see both separators used on window. |
jeremymeng
deleted the
dev-tool/bundle-warning-path-separator-windows
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that on windows some warnings are reported with
\separator while others with/at the same time, e.g.,This PR changes to try both separators when checking whether to suppress bundle warnings.