[appconfig] Fix core-client mismatch with AppConfig #24366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
added
Client
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/app-configurationDescribe the problem that is addressed by this PR
CI was failing because appconfig was pulling in the public version of
core-http-compat(1.3.0) which causes an interesting quirk in rush: core-http-compat pulled in the public version of core-client (1.6.1) while appconfig itself pulled in the repo version of core-client (1.7.0).Since AppConfig was removing and re-adding the deserializationPolicy from the pipeline, this meant the deserializationPolicy from 1.7.0 was not able to access the OperationSpec stored by the ServiceClient from 1.6.1.
In practice this issue is less likely to occur in the wild since most package managers would consolidate down to a single version of core-client and there are not pre-release local versions to choose from.
The fix in this PR is to correctly leverage our internal pipeline options to avoid having to remove and re-add the deserializationPolicy from the pipeline which avoids the problem entirely.