Min-max testing for Common package : Separate folder & Pipeline creation #24225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le for pipeline creation
ghost
added
the
|
/azp run js - communication-common - tests |
|
No pipelines are associated with this pull request. |
|
API change check API changes are not detected in this pull request. |
|
/azp run prepare-pipelines |
|
Azure Pipelines failed to run 1 pipeline(s). |
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Dec 15, 2022
Was trying to set up live test pipeline for this [pr](Azure/azure-sdk-for-js#24225). The prepare-pipeline job failed due to [not being able to find install-pipeline-generation.yml](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2056101&view=results).
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…jafferi-msft/azure-sdk-for-js into minmaxtesting_folderseparation
mjafferi-msft
commented
Dec 21, 2022
| @@ -23,7 +23,7 @@ | |||
| "extract-api": "tsc -p . && api-extractor run --local", | |||
| "format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", | |||
| "integration-test:browser": "karma start --single-run", | |||
| "integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --full-trace -t 300000 dist-esm/test/*.spec.js dist-esm/test/node/*.spec.js", | |||
| "integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --full-trace -t 300000 dist-esm/test/**/*.spec.js dist-esm/test/node/*.spec.js", | |||
There was a problem hiding this comment.
This change is because test files has now been moved to test/public or test/internal folders and is needed to show coverage summary.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-common - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-common - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-common - tests |
|
Pull request contains merge conflicts. |
|
/azp run js - communication-common - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mjafferi-msft
requested review from
ckairen,
benbp,
petrsvihlik,
AikoBB,
maximrytych-ms and
ostoliarova-msft
as code owners
petrsvihlik
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
communication-common
Issues associated with this PR
Describe the problem that is addressed by this PR
Created 2 folders under test folder :
- public which contains all the tests eligible for min-max testing
- internal that contains tests that access private/internal members
Fixed tests that were failing when object instance was checked possibly due to different package versions referenced.
Added tests.yml file to the Common package which is responsible for creating live test pipeline.
- Modified the matrix to skip all unnecessary jobs and just execute min-max testing
Live test pipelines created :
- Pipelines - Runs for js - communication-common - tests (azure.com)
- Pipelines - Runs for js - communication-common - tests-weekly (azure.com)
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
No new test cases are added. Just restructuring of test folder and fixing failed tests so as to enable min-max testing.
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists