[engsys] Upgrade dev dependency dotenv version to ^16.0.0 for selected packages
#24020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected packages to have pipelines' validation.
jeremymeng
requested review from
praveenkuttappan,
witemple-msft,
deyaaeldeen,
mikeharder,
ckairen,
weshaggard,
benbp,
EmmaZhu,
XiaoningLiu,
vinjiang,
jiacfan,
ljian3377,
HarshaNalluru,
KarishmaGhiya and
schaabs
as code owners
ghost
added
Azure.Identity
Service Bus
Storage
|
API change check API changes are not detected in this pull request. |
deyaaeldeen
approved these changes
Nov 28, 2022
| @@ -112,7 +112,7 @@ | |||
| "chai": "^4.2.0", | |||
| "chai-as-promised": "^7.1.1", | |||
| "cross-env": "^7.0.2", | |||
| "dotenv": "^8.2.0", | |||
There was a problem hiding this comment.
The recorder offers env that works in both node and browser.
I'd say we don't even need to depend on dotenv.
This PR might be a good point to check out since there aren't too many packages?
There was a problem hiding this comment.
I believe we need dotenv for samples, right?
KarishmaGhiya
pushed a commit
that referenced
this pull request
Dec 6, 2022
…ected packages (#24020)
KarishmaGhiya
pushed a commit
that referenced
this pull request
Apr 13, 2023
…ected packages (#24020)
KarishmaGhiya
pushed a commit
that referenced
this pull request
May 5, 2023
…ected packages (#24020)
KarishmaGhiya
added a commit
that referenced
this pull request
May 8, 2023
update the version and changelog update api update api view fix tests [engsys] Upgrade dev dependency `dotenv` version to `^16.0.0` for selected packages (#24020) Update eng/common/scripts/get-codeowners.ps1 Update get-codeowners.ps1 update Sync eng/common directory with azure-sdk-tools for PR 5608 (#25133) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#5608 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Konrad Jamrozik <[email protected]> update changelog Update eng/common/scripts/get-codeowners.ps1 update update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to have pipelines' validation.