[Azure Monitor Exporter] Add network Statsbeat Metrics #23425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request duration logic, and start outlining where statsbeat changes need to be made in the base exporter.
ghost
added
the
hectorhdzg
reviewed
Oct 7, 2022
hectorhdzg
reviewed
Oct 7, 2022
hectorhdzg
reviewed
Oct 7, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/constants.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 7, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/constants.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 7, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/utils/metricUtils.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
changed the title
hectorhdzg
reviewed
Oct 21, 2022
hectorhdzg
reviewed
Oct 21, 2022
hectorhdzg
reviewed
Oct 21, 2022
hectorhdzg
reviewed
Oct 21, 2022
hectorhdzg
reviewed
Oct 21, 2022
hectorhdzg
reviewed
Oct 21, 2022
hectorhdzg
reviewed
Oct 21, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/constants.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 21, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/statsbeat/statsbeatMetrics.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 21, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/statsbeat/statsbeatMetrics.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Hector Hernandez <[email protected]>
hectorhdzg
reviewed
Oct 21, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/statsbeat/statsbeatMetrics.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 21, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/statsbeat/statsbeatMetrics.ts
Outdated
Show resolved
Hide resolved
hectorhdzg
reviewed
Oct 21, 2022
sdk/monitor/monitor-opentelemetry-exporter/src/export/metric.ts
Outdated
Show resolved
Hide resolved
…and document statsbeatExporter.
mpodwysocki
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Implement statsbeat state and begin setting up the statsbeatMetrics. * Stub statsBeat metrics file. * Add a number of custom features to the network statsbeat and begin defining them. * Add _getAzureComputeMetadata logic. * Get successful count using he observable gauge. * Add the rest of the counts to the statsbeat metrics. * Update the getAverageDuration method. * Add statsbeatMetricHandler to manage the meter provider. * Update the statsbeatMetricsHandler exporter config. * Converge the statsbeat logic into one file, begin fixing the average request duration logic, and start outlining where statsbeat changes need to be made in the base exporter. * Fix issues with statsbeat connection and setup. * Add duration counting on success and failure requests. * Make batched observable results in Statsbeat. * Testing begin. * Remove isStatsbeat being user configurable. * Fix typo. * Address code review comments. * Remove intentionally broken test. * Fix dependencies issues and format * WIP * WIP * Manage the isStatsbeatExporter state in the baseExpoerter properly. * WIP * Update statsbeat names. * Revert pnpm-lock.yaml file. * Fix tests * Fix how attributes are created and how EU endpoints are set. * Add statsbeat tests. * Fix package.json file. * Continue work on tests. * Write all non-AzureVM tests. * Save progress on attempt to fix the Azure VM test. * Fix Azure VM http call. * Fix test for AzureVM. * Remove comments. * Clean up further comments. * Update changelog. * Remove unneded sinon import. * Fix sinon types import. * Fix import build issues. * Update sdk/monitor/monitor-opentelemetry-exporter/CHANGELOG.md Co-authored-by: Hector Hernandez <[email protected]> * Fix lint issues. * Address initial code review comments. * Clean up and optimize statsbeat metrics collection logic. * Update statsbeat logic to reduce checks and improve efficiency. * Fix format. * Remove last of unnecessary check. * Create statsbeatExporter to replace use of metricExporter for statsbeat. * Improve statsbeat metric exporting logic, handle legacy statusCodes, and document statsbeatExporter. * Fix formatting. Co-authored-by: Hector Hernandez <[email protected]>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
Issues associated with this PR
Describe the problem that is addressed by this PR
This PR adds exporting of short interval (every 15 minutes) StatsBeat metrics.
Are there test cases added in this PR? (If not, why?)
Yes
Checklists