Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Onboarding maps-route package #23340

Closed
wants to merge 325 commits into from

Conversation

andykao1213
Copy link
Member

Packages impacted by this PR

  • @azure/maps-route

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

  • Onboarding the maps-route package for the Azure Maps customer.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

NA

Are there test cases added in this PR? (If not, why?)

Yes, pleas refer to sdk/maps/maps-route/test

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

NA

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@andykao1213 andykao1213 self-assigned this Sep 28, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 28, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-maps-search
azure-maps-route
azure-maps-common

@andykao1213
Copy link
Member Author

Here is the previous API view: https://apiview.dev/Assemblies/Review/5e82a4ccfd8e4005a3e6efc53939cfde

@andykao1213
Copy link
Member Author

We have released the RLC version in #23588 , so this PR is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants