Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Onboarding maps-common & maps-search package #23039

Merged
merged 177 commits into from
Sep 30, 2022
Merged
Changes from 1 commit
Commits
Show all changes
177 commits
Select commit Hold shift + click to select a range
d4f8309
Add maps-search
alankashiwa Dec 8, 2021
8e401b7
Rename LatLong to LatLon
alankashiwa Dec 8, 2021
433ef7b
Fix constructor Readme doc
alankashiwa Dec 8, 2021
f1e42e9
Update readme to new signature
alankashiwa Dec 9, 2021
22d94af
Add tests partially
alankashiwa Dec 9, 2021
131542c
Change LatLon/BoundingBox to interfaces
alankashiwa Dec 10, 2021
87be993
Reduce the number of constructor overloading
alankashiwa Dec 10, 2021
9ccce79
Rename SearchClient as MapsSearchClient
alankashiwa Dec 13, 2021
cbd365b
Add options mapper tests
alankashiwa Dec 16, 2021
0bf9cf0
Add result type mapper tests (in progress)
alankashiwa Dec 17, 2021
4e6eda4
rename clientId to mapsAccountClientId
alankashiwa Dec 21, 2021
bbfcccd
listPolygons -> getPolygons
alankashiwa Dec 22, 2021
c26cbe1
getPointOfInterestCategoryTree -> getPointOfInterestCategories
alankashiwa Dec 22, 2021
78da7b5
Expose missing model
alankashiwa Dec 23, 2021
3a90436
Add alternative input file for quick experiment
alankashiwa Dec 25, 2021
01fb651
Regenerate code and make changes accordingly
alankashiwa Dec 30, 2021
570351f
Reduce number of overloads of fuzzy searches
alankashiwa Dec 31, 2021
cb7814b
Add geojson types
alankashiwa Jan 1, 2022
7a59eb9
Adopting new geojson definitions
alankashiwa Jan 3, 2022
d42a7d6
Change test specs to align with new method names
alankashiwa Jan 3, 2022
be6e5a7
clean up models and tsconfig
alankashiwa Jan 7, 2022
9b50784
Expose Known* models
alankashiwa Jan 7, 2022
d436d1f
Remove batch sync methods
alankashiwa Feb 11, 2022
48e8252
Add public tests (non-batch)
alankashiwa Feb 11, 2022
09ccde4
move model
alankashiwa Feb 14, 2022
2f712db
Add docstrings
alankashiwa Feb 17, 2022
32b43ef
Start polling in begin* method
alankashiwa Feb 17, 2022
561f8e7
Refactor BatchPoller for retrieving batchId
alankashiwa Feb 17, 2022
01e283c
Finalize batch pollers
alankashiwa Feb 18, 2022
b407301
Readd batch methods
alankashiwa Feb 18, 2022
07c4915
Update generated code
alankashiwa Feb 21, 2022
f46ff1a
Finalize batch signature
alankashiwa Feb 22, 2022
8aa43f9
Rebuild samples & clean up
alankashiwa Feb 22, 2022
50a2830
Add AAD tests
alankashiwa Feb 22, 2022
2e3906a
Clean up Swagger readme
alankashiwa Feb 23, 2022
518cd3a
Fix spelling
alankashiwa Feb 23, 2022
b62711e
Add initial files for @azure/maps-route module
alankashiwa Feb 23, 2022
9f7d01b
maps-search: change comments and perform formatting
alankashiwa Feb 25, 2022
1296f78
Methods options and testing skeleton for maps-route
alankashiwa Feb 25, 2022
98556c6
maps-search: refactor options
alankashiwa Mar 10, 2022
5b01ee3
Improve convenience layer for non-LRO methods
alankashiwa Mar 13, 2022
87b625b
Change variable names
alankashiwa Mar 14, 2022
1859f98
Complete batch methods
alankashiwa Mar 14, 2022
350a666
update maps-search Readme
alankashiwa Mar 14, 2022
81b4048
Update maps-route Readme
alankashiwa Mar 14, 2022
eb873ff
Add generated samples for maps-route
alankashiwa Mar 14, 2022
20d8ebb
Update samples for maps-search
alankashiwa Mar 14, 2022
d93f569
Delete backup file
alankashiwa Mar 14, 2022
2d9cbc9
Add maps-common module
alankashiwa Mar 15, 2022
180d729
Update maps-route/maps-search to use maps-common
alankashiwa Mar 15, 2022
618c816
maps-render: first draft
alankashiwa Mar 16, 2022
a99b00c
Use LatLon/BoundingBox from maps-common
alankashiwa Mar 17, 2022
ca3dff8
Complete maps-render with tests
alankashiwa Mar 23, 2022
f8022c2
Expose required types from maps-route
alankashiwa Mar 23, 2022
b62ce48
Expose required types from maps-search
alankashiwa Mar 23, 2022
60547a8
Complete unit tests for maps-render
alankashiwa Mar 30, 2022
e3090b4
Update maps-render README
alankashiwa Apr 1, 2022
8c7c360
Update samples
alankashiwa Apr 1, 2022
2401d0b
Fix comment/strings
alankashiwa Apr 16, 2022
1118032
Fix comment/strings
alankashiwa Apr 16, 2022
374d34c
Update Route comment/interface
alankashiwa May 1, 2022
c09435e
Regenerate code
alankashiwa Jun 15, 2022
bf5942c
Update files
alankashiwa Jun 15, 2022
ac07db8
Define required fields and fix code
alankashiwa Jun 22, 2022
3aecba3
Remove non-poller batch methods
alankashiwa Jun 22, 2022
eb48767
Fix playback test failure
alankashiwa Jun 22, 2022
6d30a03
Rename parts of model names
alankashiwa Jun 23, 2022
1f4fe2f
Rename remaining parts of models according to review feedback
alankashiwa Jun 23, 2022
48a5da5
Remove TODO comments
alankashiwa Jun 24, 2022
1c6183d
Update Reamdme transform to reflect latest swagger
alankashiwa Jun 24, 2022
674fa88
Change key policy name
alankashiwa Jun 24, 2022
4a58d7a
Simplify batch item error model
alankashiwa Jun 24, 2022
d18eaa1
Add brower tests
alankashiwa Jun 27, 2022
778ffbd
Turn maps-common into internal module
alankashiwa Jun 27, 2022
d9d8e54
Rearrange Readme
alankashiwa Jun 28, 2022
030e858
Rewrite Readme for common
alankashiwa Jun 28, 2022
c4de382
Remove batch-sync methods
alankashiwa Jun 28, 2022
1d05756
Route required fields: part 1
alankashiwa Jun 28, 2022
7a63a97
Route required fields: part 2
alankashiwa Jun 29, 2022
1512495
Add AAD back
alankashiwa Jun 29, 2022
08120d8
Route model fixes #1
alankashiwa Jun 30, 2022
a6968c5
Route model fixes #2 + geojson named tuples
alankashiwa Jun 30, 2022
1deae71
Refine geojson types
alankashiwa Jun 30, 2022
f26928e
Aliased a few method options
alankashiwa Jun 30, 2022
3c3b07f
maps-render required fields part 1
alankashiwa Jul 1, 2022
9ff7205
Do not validate budget parameters
alankashiwa Jul 1, 2022
6317cb6
Revert "Do not validate budget parameters"
alankashiwa Jul 4, 2022
924d2b9
Rename MapTileset to TileJson
alankashiwa Jul 4, 2022
016c1b8
Render: model rename & type improvement
alankashiwa Jul 4, 2022
ccac978
Explicitly transform image range
alankashiwa Jul 5, 2022
7c846e0
Fix route record tests
alankashiwa Jul 13, 2022
4076e5e
Update map account creation commands in Readme
alankashiwa Jul 13, 2022
97b4cad
Update Readme/docstrings/samples for Search/Route/Render
alankashiwa Jul 13, 2022
c76037d
Remove rollup and use dev-tool instead
dubiety Jul 13, 2022
dd6a20e
Remove some empty tests
Jul 13, 2022
9bd0ca1
Add AAD test case and make file name shorter
Jul 13, 2022
35de7ad
Update test cases
Jul 14, 2022
4bc9068
Update cspell rules
dubiety Jul 21, 2022
f140b56
Update recording files
dubiety Jul 18, 2022
f7d03f8
Simplify test cases
dubiety Jul 18, 2022
7cd630b
Sync cspell.json from upstream
Jul 19, 2022
9e36211
Use test-recorder 2.0 and update unit test cases
Jul 19, 2022
ab96116
Push wrong browsers recording files
Jul 19, 2022
815268c
Update settings to support recording
dubiety Jul 20, 2022
97e09fa
Fix dependency errors
dubiety Jul 21, 2022
7341f9d
Upgrade api-recorder and fix errors
Jul 26, 2022
983d9fd
Code refinement
Jul 26, 2022
364d4e5
Update maps search recording files
Jul 26, 2022
c6212ec
Update karma.conf.js format
Jul 26, 2022
65ab9cf
Update recording files and settings
Jul 26, 2022
2af9fb2
Fix broken links
Jul 26, 2022
b66237d
Update maps dependency in pnpm-lock.yaml
Jul 26, 2022
64de5e9
Fix sample metadata errors
Jul 26, 2022
8248dea
Fix linting errors
Jul 27, 2022
75cf90f
Fix linting errors
dubiety Jul 27, 2022
7863b9e
Fix run time error
Jul 27, 2022
ff5d8a5
Update package.json in samples folder
Jul 27, 2022
cce0f9e
Fix linting errors
dubiety Jul 27, 2022
45eae6e
Fix linting errors
dubiety Jul 27, 2022
33d39a7
Add changelog for maps-common
Jul 28, 2022
fe0ede3
Update recording files for maps-search
Jul 28, 2022
0f2d40c
Add test.yml for maps-search
Jul 28, 2022
e8776d5
Add tests.yml for render and route
Jul 28, 2022
098ccdc
Update tests.yml
Jul 28, 2022
3a4f796
Update test-resources.json for maps
dubiety Jul 28, 2022
c529bdd
Fix tests.yml format error
dubiety Jul 28, 2022
70596eb
Update env vars and remove unused export var
Jul 28, 2022
dc04541
Remove unused code
dubiety Jul 29, 2022
1365891
Fix lock file
andykao1213 Aug 24, 2022
9cea83b
Remove route & render
andykao1213 Aug 25, 2022
fd5ac05
Replace `beginGet*Batch` with `resume*Batch`
andykao1213 Aug 29, 2022
ea49a98
Update recording
andykao1213 Aug 29, 2022
688a2e0
Make the endpoint of `MapsSearchClient` configurable
andykao1213 Aug 31, 2022
c18836e
Change LatLon from an interface to a tuple
andykao1213 Sep 1, 2022
262e74c
Make the props `coordinates` and `countryCodeFilter` optional
andykao1213 Sep 1, 2022
64ab74f
fixup! Remove route & render
andykao1213 Sep 1, 2022
18f84ec
Adjust CHANGELOGs of maps-search & common
andykao1213 Sep 1, 2022
ea70218
Update samples
andykao1213 Sep 5, 2022
b888756
Add batchRequest sample
andykao1213 Sep 5, 2022
c03e5b4
Add a new sample searchAddressResult
andykao1213 Sep 5, 2022
f86afb8
Update search.ts and its examples
andykao1213 Sep 5, 2022
de2378c
enhance code example in README.md
andykao1213 Sep 5, 2022
4a922cc
comment unused import
andykao1213 Sep 5, 2022
e4780e7
Update recording for maps-search
andykao1213 Sep 5, 2022
bf4bd29
remove redundant recording files
andykao1213 Sep 5, 2022
5b8b57e
Comment the future doc link
andykao1213 Sep 7, 2022
435c06a
Update doc & fix type issue
andykao1213 Sep 7, 2022
bce35b2
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 8, 2022
7d06868
fix lint issues
andykao1213 Sep 13, 2022
7cc9e9e
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 13, 2022
467ce32
Regenerate API View
andykao1213 Sep 13, 2022
0e926dd
Comment the whole [apiref] since the original syntax cannot pass the …
andykao1213 Sep 13, 2022
8f3b125
Remove maps-common from the Artifacts
andykao1213 Sep 14, 2022
58afa84
remove unused dependencies
andykao1213 Sep 15, 2022
19da7ce
Add impression in README so we can track the page views
andykao1213 Sep 15, 2022
f28c0f3
Remove `AZURE_LOG_LEVEL` in test.yml
andykao1213 Sep 15, 2022
f105d20
Update samples
andykao1213 Sep 16, 2022
da93ad9
Patch {} to properties for GeoJsonPolygon
andykao1213 Sep 16, 2022
d9618a7
rename maxDetourTime to maxDetourTimeInSeconds
andykao1213 Sep 16, 2022
70e7ddd
Update recordings
andykao1213 Sep 16, 2022
1b1508c
Remove any
andykao1213 Sep 19, 2022
b5390e3
Rename to detourTimeInSeconds to align the convention
andykao1213 Sep 19, 2022
1fd4459
Change the test.yml EnvVar
andykao1213 Sep 19, 2022
a620930
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 19, 2022
5d7cf7d
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 20, 2022
d28da36
Rename numResults to numberResults
andykao1213 Sep 21, 2022
979cae7
Add document comment
andykao1213 Sep 21, 2022
502d7dc
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 21, 2022
9100bda
Make the `maps-common to a published package
andykao1213 Sep 27, 2022
76d9057
Update the import of `maps-common` in `maps-search`
andykao1213 Sep 27, 2022
a7e33ec
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 27, 2022
02a0517
Fix CI Issue
andykao1213 Sep 27, 2022
fd7722f
Add documents for geojson
andykao1213 Sep 28, 2022
384217c
chore update
andykao1213 Sep 28, 2022
01f4e60
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 28, 2022
1de07d2
Remove the method `cancelOperation`
andykao1213 Sep 30, 2022
f48c878
Merge remote-tracking branch 'upstream/main' into andrewkao/maps-search
andykao1213 Sep 30, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Turn maps-common into internal module
  • Loading branch information
alankashiwa authored and andykao1213 committed Sep 6, 2022
commit 778ffbd7f3fa06450d15f1e1a3ba57ec8b6bbfa3
2 changes: 1 addition & 1 deletion rush.json
Original file line number Diff line number Diff line change
@@ -614,7 +614,7 @@
{
"packageName": "@azure/maps-common",
"projectFolder": "sdk/maps/maps-common",
"versionPolicyName": "client"
"versionPolicyName": "utility"
},
{
"packageName": "@azure/maps-search",
19 changes: 0 additions & 19 deletions sdk/maps/maps-common/.nycrc

This file was deleted.

7 changes: 0 additions & 7 deletions sdk/maps/maps-common/CHANGELOG.md

This file was deleted.

21 changes: 0 additions & 21 deletions sdk/maps/maps-common/LICENSE

This file was deleted.

35 changes: 0 additions & 35 deletions sdk/maps/maps-common/api-extractor.json

This file was deleted.

31 changes: 0 additions & 31 deletions sdk/maps/maps-common/api-extractor.json.bak

This file was deleted.

147 changes: 0 additions & 147 deletions sdk/maps/maps-common/karma.conf.js

This file was deleted.

27 changes: 13 additions & 14 deletions sdk/maps/maps-common/package.json
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
"description": "A client library for Azure Maps maps-common",
"sdk-type": "client",
"main": "dist/index.js",
"module": "dist-esm/src/index.js",
"module": "dist-esm/index.js",
"browser": {},
"types": "types/maps-common.d.ts",
"typesVersions": {
@@ -26,31 +26,30 @@
}
},
"scripts": {
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
"build:samples": "echo Obsolete",
"build:test": "tsc -p . && rollup -c 2>&1",
"audit": "echo skipped",
"build:samples": "echo skipped",
"build:test": "echo skipped",
"build": "tsc -p . && rollup -c 2>&1 && npm run build:types",
"build:types": "downlevel-dts types types/3.1",
"build": "tsc -p . && rollup -c 2>&1 && api-extractor run --local && npm run build:types",
"check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
"clean": "rimraf dist dist-* temp types *.tgz *.log",
"docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --stripInternal --mode file --out ./dist/docs ./src",
"docs": "echo skipped",
"execute:samples": "dev-tool samples run samples-dev",
"publish:samples": "dev-tool samples publish -f",
"extract-api": "tsc -p . && api-extractor run --local",
"extract-api": "echo skipped",
"format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
"generate:client": "autorest --typescript --v3 swagger",
"integration-test:browser": "karma start --single-run",
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 5000000 --full-trace \"dist-esm/test/{,!(browser)/**/}/*.spec.js\"",
"integration-test:browser": "echo skipped",
"integration-test:node": "echo skipped",
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json api-extractor.json src test --ext .ts",
"lint:fix": "eslint package.json src test --ext .ts --fix --fix-type [problem,suggestion]",
"lint": "eslint package.json src test --ext .ts",
"pack": "npm pack 2>&1",
"prebuild": "npm run clean",
"test:browser": "npm run clean && npm run build:test && npm run unit-test:browser && npm run integration-test:browser",
"test:node": "npm run clean && tsc -p . && npm run unit-test:node && npm run integration-test:node",
"test": "npm run clean && tsc -p . && npm run unit-test:node && rollup -c 2>&1 && npm run unit-test:browser && npm run integration-test",
"unit-test:browser": "karma start --single-run",
"unit-test:node": "mocha -r esm -r ts-node/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace --exclude \"test/**/browser/*.spec.ts\" \"test/**/*.spec.ts\"",
"unit-test:browser": "echo skipped",
"unit-test:node": "echo skipped",
"unit-test": "npm run unit-test:node && npm run unit-test:browser"
},
"files": [
Loading