Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Migrate keyvault-certificates to new recorder #22575

Merged
merged 12 commits into from
Jul 26, 2022

Conversation

timovv
Copy link
Member

@timovv timovv commented Jul 13, 2022

Packages impacted by this PR

  • @azure/keyvault-certificates

Issues associated with this PR

Migrates keyvault-certificates to the new recorder. Fairly straightforward.

@ghost ghost added the KeyVault label Jul 14, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@timovv timovv marked this pull request as ready for review July 19, 2022 20:32
Copy link
Member

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment regarding unskipping tests.
Looks good overall.

@timovv
Copy link
Member Author

timovv commented Jul 26, 2022

Re-skipping the timeout tests for now since it seems like we have some weird race condition going on where tests fail sometimes in CI.

@timovv timovv merged commit 4bcbc53 into Azure:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Vault Cert - Move to the new proxy server based recorder
4 participants