Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cosmos with azure core tracing #22284

Merged
merged 6 commits into from
Jun 28, 2022
Merged

upgrade cosmos with azure core tracing #22284

merged 6 commits into from
Jun 28, 2022

Conversation

jay-most
Copy link
Contributor

Update Cosmos to use Azure Core Tracing.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@ghost ghost added the Cosmos label Jun 16, 2022
Copy link
Member

@sajeetharan sajeetharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will let @xirzec's comment on the package dependency

xirzec
xirzec previously requested changes Jun 17, 2022
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work, are you planning to add any instrumentation to the client?

sdk/cosmosdb/cosmos/package.json Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/review/cosmos.api.md Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/src/utils/tracing.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jay-most jay-most left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in a later commit.

@witemple-msft witemple-msft requested a review from joheredi June 22, 2022 20:43
sdk/cosmosdb/cosmos/package.json Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/package.json Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/package.json Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/src/utils/tracing.ts Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/src/utils/tracing.ts Show resolved Hide resolved
sdk/cosmosdb/cosmos/package.json Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/src/utils/tracing.ts Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/src/utils/tracing.ts Outdated Show resolved Hide resolved
sdk/cosmosdb/cosmos/src/common/constants.ts Outdated Show resolved Hide resolved
@jay-most jay-most dismissed xirzec’s stale review June 28, 2022 19:51

Reviewer's question was answered and other code changes were considered.

@jay-most jay-most enabled auto-merge (squash) June 28, 2022 19:58
@jay-most jay-most force-pushed the jay/cosmos-trace branch 2 times, most recently from c9524e3 to e4607f8 Compare June 28, 2022 20:54
@jay-most jay-most merged commit 0cdb39a into main Jun 28, 2022
@jay-most jay-most deleted the jay/cosmos-trace branch June 28, 2022 23:13
@jay-most jay-most mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants