Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Registry Avro] Fix test #21660

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Apr 28, 2022

Packages impacted by this PR

@azure/schema-registry-avro

Issues associated with this PR

Describe the problem that is addressed by this PR

Mocked error message didn't match live test error message.

Failed run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1534686&view=logs&j=b800360f-d572-5e16-3e20-e4f204d3fbd3&t=3b97752f-f53c-5e36-3379-45368efa0b3c

Successful run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1535009&view=results

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

N/A

Are there test cases added in this PR? (If not, why?)

N/A

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the Schema Registry label Apr 28, 2022
@azure-sdk
Copy link
Collaborator

API change check for @azure/schema-registry-avro

API changes are not detected in this pull request for @azure/schema-registry-avro

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@deyaaeldeen deyaaeldeen merged commit 67946c5 into Azure:main Apr 28, 2022
@deyaaeldeen deyaaeldeen deleted the schemaregistryavro/fix-test branch April 28, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants