Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monitor-query][test] fix build error #21550

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

jeremymeng
Copy link
Member

The test is checking a private property of ServiceClient that just got renamed.

This PR fixes the build.

The test is checking a private property of ServiceClient that just got renamed.

This PR fixes the build. Another issue will be logged to improve the test by
testing that the option is passed to ServiceClient via a mock, instead of
verifying the internals of ServiceClient
@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Apr 21, 2022
@jeremymeng
Copy link
Member Author

An issue will be logged to improve the test by testing that the option is passed to ServiceClient via a mock, instead of
verifying the internals of ServiceClient.

@jeremymeng
Copy link
Member Author

Logged #21551

@azure-sdk
Copy link
Collaborator

API change check for @azure/monitor-query

API changes are not detected in this pull request for @azure/monitor-query

@jeremymeng jeremymeng enabled auto-merge (squash) April 21, 2022 21:25
@jeremymeng jeremymeng merged commit b364cc8 into Azure:main Apr 21, 2022
@jeremymeng jeremymeng deleted the monitor/react-core-change branch April 21, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants