Fix error handling in deleteTable #21408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
6 tasks
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Nov 18, 2022
[service connector]add api version 2022-11-01-preview (Azure#21408) * add api version 2022-11-01-preview * fix api versions in sample * fix sample * add dryrun to custom words * update configurationNames API Co-authored-by: xiaofanzhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@Azure/data-tables
Issues associated with this PR
#21385
Describe the problem that is addressed by this PR
When migrating to the new @azure/core-tracing version we accidentally removed the code that throws when a delete operation returns a non-404 status code
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Added back the deleted code
Are there test cases added in this PR? (If not, why?)
Yes, added test to prevent this regression from happening again
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
n/a
Checklists