[Recorder] Do not set private to true to be able to release #21356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
xirzec,
joheredi,
JonathanCrd,
jeremymeng and
deyaaeldeen
|
/check-enforcer override |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Nov 14, 2022
[Hub Generated] Review request for Microsoft.LoadTestService to add version stable/2022-12-01 (Azure#21356) * changes needed for autorest cli * adding nullable property for UAMI * changed namespace for go,py,js * updated markdown files * deleted unused markdown * updated tags nullability * updated c# output folder * moving MI nullability away from common types * added x-nullable property to user MI * updated enum value * fix model validation failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline failed because of https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1497447&view=logs&j=5742d1c6-78e5-56de-b8e3-8788f4b41836&t=6c758387-9fbb-54a1-8544-1f7c5bb76fbc.
Unsetting
"private" : "true"in package.json.This has to be the last hurdle and should do trick to release