Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/communication-sms Azure Core 2.0 Migration #21292

Closed

Conversation

arifibrahim4
Copy link
Member

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the Communication label Apr 7, 2022
@azure-sdk
Copy link
Collaborator

API change check for @azure/communication-sms

API changes have been detected in @azure/communication-sms. You can review API changes here

API changes

- export interface SmsClientOptions extends PipelineOptions { }
+ export interface SmsClientOptions extends CommonClientOptions { }

@petrsvihlik petrsvihlik changed the title Feature/sms core v2 migration @azure/communication-sms Azure Core 2.0 Migration Apr 11, 2022
@petrsvihlik
Copy link
Contributor

fixes #20402

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Nov 7, 2022
OperationalInsights 2022-10-01: Changing retentionInDaysAsDefault to boolean. (Azure#21292)

* OperationalInsights: 2022-10-01 stable version

* Actual changes.

* More fixes.

* more changes.

* Removing redundant breaking change.

* Workspace identity: referencing standard types.

* Referencing managed identity standard type, refactoring booleans into enum.

* Fixing examples.

* Removing duplicate resource.

* Update Workspaces.json

* Update Clusters.json

* Revert "Update Clusters.json"

This reverts commit 4eb99cf4699afeb95dc2bab1ee071c7d4f9ee2c5.

* Revert "Update Workspaces.json"

This reverts commit c16bc82f2ec8a35131c1ec54d2dca147eca929d1.

* Returning to our identity implementation.

* OperationalInsights 2022-10-01: Changing retentionInDaysAsDefault to boolean representation.

* redundant comma.

* redundant comma.

* Adding missing example header.

* Update TablesDelete.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants