Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/communication-network-traversal Azure Core 2.0 Migration #21193

Merged
merged 10 commits into from
Apr 26, 2022

Conversation

AriZavala2
Copy link
Contributor

Packages impacted by this PR

Azure communication services network traversal.

Issues associated with this PR

Migration to Azure core 2.0

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the Communication label Apr 5, 2022
@petrsvihlik petrsvihlik changed the title Migration to Azure core 2.0 @azure/communication-network-traversal Azure Core 2.0 Migration Apr 11, 2022
@AriZavala2 AriZavala2 force-pushed the AriZavala2/update_auth_policy branch from 9ae85a3 to d271aec Compare April 13, 2022 00:20
@azure-sdk
Copy link
Collaborator

API change check for @azure/communication-network-traversal

API changes have been detected in @azure/communication-network-traversal. You can review API changes here

API changes

- export interface CommunicationRelayClientOptions extends PipelineOptions { }
+ export interface CommunicationRelayClientOptions extends CommonClientOptions { }
- export declare type RouteType = "any" | "nearest";
+ export declare enum KnownRouteType 
+ export declare type RouteType = string;

@AriZavala2 AriZavala2 force-pushed the AriZavala2/update_auth_policy branch from d271aec to 3405f42 Compare April 13, 2022 04:28
@AriZavala2 AriZavala2 force-pushed the AriZavala2/update_auth_policy branch from 3405f42 to b812e57 Compare April 21, 2022 18:52
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@AriZavala2 AriZavala2 marked this pull request as ready for review April 21, 2022 21:12
@AriZavala2 AriZavala2 force-pushed the AriZavala2/update_auth_policy branch from e4e5ce9 to 960f28a Compare April 21, 2022 23:01
Copy link
Contributor

@petrsvihlik petrsvihlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments, otherwise, it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants