-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@azure/communication-network-traversal Azure Core 2.0 Migration #21193
@azure/communication-network-traversal Azure Core 2.0 Migration #21193
Conversation
9ae85a3
to
d271aec
Compare
API change check for API changes have been detected in API changes - export interface CommunicationRelayClientOptions extends PipelineOptions { }
+ export interface CommunicationRelayClientOptions extends CommonClientOptions { }
- export declare type RouteType = "any" | "nearest";
+ export declare enum KnownRouteType
+ export declare type RouteType = string; |
d271aec
to
3405f42
Compare
3405f42
to
b812e57
Compare
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
e4e5ce9
to
960f28a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments, otherwise, it looks good.
Packages impacted by this PR
Azure communication services network traversal.
Issues associated with this PR
Migration to Azure core 2.0
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists