Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core http compat to AI Metrics Advisor #20918

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Add core http compat to AI Metrics Advisor #20918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
476e89e
Add dependency and autorest flag
JonathanCrd Mar 17, 2022
8d77619
Generate client
JonathanCrd Mar 17, 2022
587536a
Use ExtendedCommonClientOptions
JonathanCrd Mar 17, 2022
b4787d8
Merge remote-tracking branch 'upstream/main' into Add-Http-Compat-to-…
JonathanCrd Mar 29, 2022
1b992d3
Update core-http-compat to latest version
JonathanCrd Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/metricsadvisor/ai-metrics-advisor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"@azure/core-client": "^1.0.0",
"@azure/core-rest-pipeline": "^1.1.0",
"@azure/core-tracing": "1.0.0-preview.13",
"@azure/core-http-compat": "^1.2.0",
"@azure/logger": "^1.0.0",
"tslib": "^2.2.0"
},
Expand Down
6 changes: 3 additions & 3 deletions sdk/metricsadvisor/ai-metrics-advisor/review/ai-metrics-advisor.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

/// <reference lib="esnext.asynciterable" />

import { CommonClientOptions } from '@azure/core-client';
import { ExtendedCommonClientOptions } from '@azure/core-http-compat';
import { FullOperationResponse } from '@azure/core-client';
import { OperationOptions } from '@azure/core-client';
import { PagedAsyncIterableIterator } from '@azure/core-paging';
Expand Down Expand Up @@ -885,7 +885,7 @@ export class MetricsAdvisorAdministrationClient {
}

// @public
export interface MetricsAdvisorAdministrationClientOptions extends CommonClientOptions {
export interface MetricsAdvisorAdministrationClientOptions extends ExtendedCommonClientOptions {
}

// @public
Expand All @@ -910,7 +910,7 @@ export class MetricsAdvisorClient {
}

// @public
export interface MetricsAdvisorClientOptions extends CommonClientOptions {
export interface MetricsAdvisorClientOptions extends ExtendedCommonClientOptions {
}

// @public
Expand Down
36 changes: 33 additions & 3 deletions sdk/metricsadvisor/ai-metrics-advisor/src/generated/generatedClient.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/src/generated/index.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/src/generated/models/index.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorAdministrationClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
bearerTokenAuthenticationPolicy,
InternalPipelineOptions,
} from "@azure/core-rest-pipeline";
import { FullOperationResponse, OperationOptions, CommonClientOptions } from "@azure/core-client";
import { FullOperationResponse, OperationOptions } from "@azure/core-client";
import { isTokenCredential, TokenCredential } from "@azure/core-auth";
import { PagedAsyncIterableIterator, PageSettings } from "@azure/core-paging";
import "@azure/core-paging";
Expand Down Expand Up @@ -68,11 +68,12 @@ import {
MetricsAdvisorLoggingAllowedHeaderNames,
MetricsAdvisorLoggingAllowedQueryParameters,
} from "./constants";
import { ExtendedCommonClientOptions } from "@azure/core-http-compat";

/**
* Client options used to configure API requests.
*/
export interface MetricsAdvisorAdministrationClientOptions extends CommonClientOptions {}
export interface MetricsAdvisorAdministrationClientOptions extends ExtendedCommonClientOptions {}

/**
* Options for listing data feed ingestion status
Expand Down
5 changes: 3 additions & 2 deletions sdk/metricsadvisor/ai-metrics-advisor/src/metricsAdvisorClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import {
bearerTokenAuthenticationPolicy,
InternalPipelineOptions,
} from "@azure/core-rest-pipeline";
import { OperationOptions, CommonClientOptions } from "@azure/core-client";
import { PagedAsyncIterableIterator, PageSettings } from "@azure/core-paging";
import { isTokenCredential, TokenCredential } from "@azure/core-auth";
import { OperationOptions } from "@azure/core-client";
import { ExtendedCommonClientOptions } from "@azure/core-http-compat";
import { GeneratedClient } from "./generated/generatedClient";
import { createSpan } from "./tracing";
import {
Expand Down Expand Up @@ -49,7 +50,7 @@ import { logger } from "./logger";
/**
* Client options used to configure Metrics Advisor API requests.
*/
export interface MetricsAdvisorClientOptions extends CommonClientOptions {}
export interface MetricsAdvisorClientOptions extends ExtendedCommonClientOptions {}

/**
* Options for listing incidents for detection configurations
Expand Down
3 changes: 2 additions & 1 deletion sdk/metricsadvisor/ai-metrics-advisor/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ input-file: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/08f5e39
add-credentials: false
override-client-name: GeneratedClient
use-extension:
"@autorest/typescript": "6.0.0-beta.15"
"@autorest/typescript": "6.0.0-beta.16"
disable-async-iterators: true
hide-clients: true
package-version: 1.0.1
typescript: true
core-http-compat-mode: true
```

## Customizations for Track 2 Generator
Expand Down