Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 2861 #20837

Merged
merged 8 commits into from
Mar 23, 2022

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#2861 See eng/common workflow

@azure-sdk azure-sdk requested a review from sima-zhu March 15, 2022 00:05
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Mar 15, 2022
@azure-sdk azure-sdk force-pushed the sync-eng/common-use_common_scripts-2861 branch 2 times, most recently from 11b089c to a0f8bb0 Compare March 15, 2022 00:33
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@azure-sdk azure-sdk force-pushed the sync-eng/common-use_common_scripts-2861 branch 8 times, most recently from 31b2007 to 92b7cd7 Compare March 18, 2022 00:38
@azure-sdk azure-sdk force-pushed the sync-eng/common-use_common_scripts-2861 branch 3 times, most recently from ae71b44 to b1bd26e Compare March 23, 2022 21:51
@azure-sdk azure-sdk force-pushed the sync-eng/common-use_common_scripts-2861 branch from b1bd26e to 6eb4c94 Compare March 23, 2022 21:56
@azure-sdk azure-sdk merged commit 4cff1c1 into main Mar 23, 2022
@azure-sdk azure-sdk deleted the sync-eng/common-use_common_scripts-2861 branch March 23, 2022 23:59
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Oct 5, 2022
Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions (Azure#20837)

* remove x-ms-external tag for 2022-05-01 API version

* remove x-ms-external tag for 2021-06-01 API version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants