Prototype to use settings in byPage method #20809
Conversation
sarangan12
requested review from
qiaozha,
dw511214992 and
MaryGao
as code owners
| @@ -91,6 +98,31 @@ export class VirtualMachineImageTemplatesImpl | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
The following lines are moved for viewing the code easily. They are not actual code changes
| ): AsyncIterableIterator<ImageTemplate[]> { | ||
| let result = await this._list(options); | ||
| let result; | ||
| if (settings && settings.continuationToken) { |
There was a problem hiding this comment.
nit:
| if (settings && settings.continuationToken) { | |
| if (settings?.continuationToken) { |
ghost
added
the
no-recent-activity
|
Hi @sarangan12. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @sarangan12. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Packages impacted by this PR
None. This PR is created as a Prototype to show the changes required for Issue Azure/autorest.typescript#1199. We do not have to merge this PR.
Issues associated with this PR
Azure/autorest.typescript#1199
Describe the problem that is addressed by this PR
During the discussion with @deyaaeldeen, he has pointed out that the settings parameter should be used in the byPage method. And, the token in the settings must be used as the next url. I believe this code change will satisfy that requirement.
(Another requirement on maxPageSize is not done here yet. I am working on that)
@deyaaeldeen Could you please take a look at this PR and let me know if it satisfy the ask?
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists