[identity] add support for app service 2019 #20789
Conversation
KarishmaGhiya
requested review from
sadasant,
witemple-msft and
schaabs
as code owners
ghost
added
the
| logger.info( | ||
| `${msiName}: Using the endpoint and the secret coming form the environment variables: IDENTITY_ENDPOINT=${process.env.IDENTITY_ENDPOINT} and IDENTITY_HEADER=[REDACTED].` | ||
| ); | ||
|
|
There was a problem hiding this comment.
@sadasant Can we go over the log warnings and info if they are appropriate for this? Also do we need any logs for clientId ?
| @@ -507,6 +507,82 @@ describe("ManagedIdentityCredential", function () { | |||
| } | |||
| }); | |||
|
|
|||
| it("sends an authorization request correctly in an App Service 2019 environment by client id", async () => { | |||
There was a problem hiding this comment.
Note: Follow up with the crew in standup - do we need to remove support for App service 2017 version?
There was a problem hiding this comment.
ok turns out we should not remove 2017! So this PR is good 🙂
|
The tests are failing due to some errors:
Still investigating this. |
There was a problem hiding this comment.
I had forgotten, but we also need to add this MSI to the list of MSIs on the ManagedIdentityCredential/index.ts file.
We also need a flag to enable this (or 2017’s) on ManagedIdentityCredential/index.ts — follow up with Scott Schaab or Christopher Scott. As per Bill Wert, the env variables are the flags to enable either MSI, and we already cover that, so we just need to add this MSI to the list of MSIs.
|
Looks good from the Identity perspective. |
|
@KarishmaGhiya when you add the MSI in the MSI list, add it before the 2017 entry. Then, you can mark this issue* as fixed: #20954 |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
Review request for Microsoft.ContainerService to add version 2022-08-03-preview (Azure#20789) * Adds base for updating Microsoft.ContainerService from version preview/2022-08-02-preview to version 2022-08-03-preview * Updates readme * Updates API version in new specs and examples * update readmes (Azure#20708) * feat: add rest api spec for ipTags (Azure#20744) Co-authored-by: Qi Ni <[email protected]>
Packages impacted by this PR
@azure/identity
Issues associated with this PR
Fixes #20466
Describe the problem that is addressed by this PR
Design description -
#20466 (comment)
Checklists