Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Azure Authentication support for Exporter #20422

Merged
merged 8 commits into from
Mar 8, 2022

Conversation

hectorhdzg
Copy link
Member

Packages impacted by this PR

@azure/monitor-opentelemetry-exporter

Issues associated with this PR

Describe the problem that is addressed by this PR

Add Authentication support

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Feb 17, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/monitor-opentelemetry-exporter. You can review API changes here

API changes

+     aadTokenCredential?: TokenCredential;

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@hectorhdzg hectorhdzg marked this pull request as ready for review February 18, 2022 19:16
@hectorhdzg
Copy link
Member Author

/check-enforcer reset

@maorleger
Copy link
Member

/check-enforcer evaluate

@hectorhdzg
Copy link
Member Author

/check-enforcer evaluate

@maorleger
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@maorleger
Copy link
Member

/azp run js - monitor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hectorhdzg hectorhdzg merged commit c8ab287 into Azure:main Mar 8, 2022
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this pull request Mar 20, 2022
* Adding Azure Authentication support for Exporter

* Changelog

* Ran swagger

* Build

* Update

* Empty update to kick off valdiation again

* Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants