[engsys] Enable credscan in PR/Ci #20312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremymeng
reviewed
Feb 10, 2022
| TestProxy: ${{ parameters.TestProxy }} | ||
|
|
||
| - ${{ if ne(parameters.RunUnitTests, false) }}: | ||
| - template: /eng/common/pipelines/templates/jobs/archetype-sdk-tests-generate.yml |
There was a problem hiding this comment.
Looks that - template now has more indentation? It was aligning with $ previously. Not sure if it matters though.
There was a problem hiding this comment.
Yes not only does the indention look off it looks like this is in the incorrect spot. It should be above the Compliance job.
There was a problem hiding this comment.
Actually nevermind about the ordering as this is an entire job template so it can go above or below the Compliance job. However do double check the indention.
There was a problem hiding this comment.
It is working as expected and indentation is correct.
jeremymeng
changed the title
jeremymeng
approved these changes
Feb 10, 2022
maorleger
reviewed
Feb 10, 2022
| CloudConfig: | ||
| Cloud: Public | ||
| AdditionalParameters: | ||
| - job: Compliance |
There was a problem hiding this comment.
Don't know enough to approve but just want to say I am very excited to have this!
weshaggard
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable credscan in PR/Ci