Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sort-imports] enforce sort-imports rule in identity-cache-persistence #20109

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

bzhang0
Copy link
Contributor

@bzhang0 bzhang0 commented Jan 28, 2022

This PR reinforces the changes made in #19067 by changing the subdirectory's linting rule to "sort-imports": "error".

This affects the directory under sdk/identity/identity-cache-persistence.

@ghost ghost added Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 28, 2022
@ghost
Copy link

ghost commented Jan 28, 2022

Thank you for your contribution bzhang0! We will review the pull request and get back to you soon.

@ghost ghost added the Impact++ This pull request was submitted by a member of the Impact++ team. label Jan 28, 2022
Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

On the build failures: our Identity CI is having some trouble, and we're looking into it.

@bzhang0
Copy link
Contributor Author

bzhang0 commented Jan 28, 2022

Thank you!

On the build failures: our Identity CI is having some trouble, and we're looking into it.

No worries at all! Thank you for your time :D

@check-enforcer
Copy link

check-enforcer bot commented Feb 9, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@jeremymeng jeremymeng merged commit 4b81b90 into Azure:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity customer-reported Issues that are reported by GitHub users external to the Azure organization. Impact++ This pull request was submitted by a member of the Impact++ team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants